feat: Implement the calculation of tokens amounts #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Sep 27, 2024
n13
requested changes
Sep 27, 2024
|
Please use these accessors to conver the asset values into doubles - I added computed values to ProposalModelDetails |
# Conflicts: # lib/ui/proposals/details/components/proposal_details_view.dart
n13
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Looking good now
I wonder if cycle duration also comes with settings?
I saw you're getting period seconds from settings now... maybe cycle seconds are there too? Would be more accurate.
Once we start testing we need to compare the amounts with the web to make sure it's the same.
|
@n13 cycle duration doesn't exist in the settings. I followed the web implementation, and they set its value statically as i did on the mobile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented dynamic token amount updates based on the toggle switch to calculate the token amount per period or for one cycle, ensuring proper handling of cases where no tokens are available. When tokens are absent, the toggle switch and token-related UI elements are hidden to enhance the user experience by only displaying relevant information.
Screenshots